Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

New example: voltage clamp #408

Merged
merged 15 commits into from
Aug 28, 2024
Merged

New example: voltage clamp #408

merged 15 commits into from
Aug 28, 2024

Conversation

AurelienJaquier
Copy link
Collaborator

@AurelienJaquier AurelienJaquier commented Aug 13, 2024 •
edited
Loading

Description

New example: voltage clamp with data from channelpedia and jupyter notebook

Checklist:

  • Unit tests are added to cover the changes (skip if not applicable).
  • The changes are mentioned in the documentation (skip if not applicable).
  • CHANGELOG file is updated (skip if not applicable).

@AurelienJaquier AurelienJaquier self-assigned this Aug 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.83333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 92.22%. Comparing base (2cddd26) to head (1c765be).
Report is 31 commits behind head on master.

Files Patch % Lines
efel/pyfeatures/pyfeatures.py 84.37% 10 Missing ⚠️
tests/test_pyfeatures.py 98.07% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #408      +/-   ##
==========================================
+ Coverage   91.73%   92.22%   +0.48%     
==========================================
  Files          36       39       +3     
  Lines        6278     7509    +1231     
  Branches     2033     2297     +264     
==========================================
+ Hits         5759     6925    +1166     
- Misses        266      300      +34     
- Partials      253      284      +31

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AurelienJaquier AurelienJaquier marked this pull request as draft August 23, 2024 11:57
@AurelienJaquier AurelienJaquier marked this pull request as ready for review August 26, 2024 08:01
ilkilic
ilkilic reviewed Aug 26, 2024
View reviewed changes
ilkilic
ilkilic reviewed Aug 26, 2024
View reviewed changes
ilkilic
ilkilic reviewed Aug 26, 2024
View reviewed changes
@AurelienJaquier
Copy link
Collaborator Author

I also added fitting curves to the plot of the example as requested by @darshanmandge in latest commit

darshanmandge
darshanmandge approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@darshanmandge darshanmandge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AurelienJaquier !

ilkilic
ilkilic approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@ilkilic ilkilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @AurelienJaquier !

@AurelienJaquier AurelienJaquier merged commit e9bcd51 into BlueBrain:master Aug 28, 2024
20 checks passed
@AurelienJaquier AurelienJaquier deleted the voltage-clamp-example branch August 28, 2024 07:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@darshanmandge darshanmandge darshanmandge approved these changes

@ilkilic ilkilic ilkilic approved these changes

Assignees

@AurelienJaquier AurelienJaquier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AurelienJaquier @codecov-commenter @darshanmandge @ilkilic